Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to see sync concept if it is not coded concept #1145

Closed
vedfordev opened this issue Feb 29, 2024 · 9 comments · Fixed by #1148
Closed

Unable to see sync concept if it is not coded concept #1145

vedfordev opened this issue Feb 29, 2024 · 9 comments · Fixed by #1148
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vedfordev
Copy link
Contributor

Describe the bug
we made changes to show sync attribute values which was earlier shows as uuids. but currently for non coded concept it is not showing the value as screenshot

To Reproduce
Steps to reproduce the behaviour:

  1. Go to goonj organization
  2. Open user who has sync attribute
  3. See the user

Expected behaviour
Handle scenario for both coded and not coded sync attribute value.

Screenshots
Screenshot 2024-02-29 at 11 47 09 AM

@vedfordev vedfordev added the bug Something isn't working label Feb 29, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Feb 29, 2024
@mahalakshme
Copy link
Contributor

already a card is there for this

@mahalakshme
Copy link
Contributor

@mahalakshme mahalakshme added the good first issue Good for newcomers label Feb 29, 2024
vedfordev added a commit to vedfordev/avni-webapp that referenced this issue Mar 1, 2024
…erDetail, added cleanup function and reduce the api calls for coded concept
@vedfordev vedfordev mentioned this issue Mar 2, 2024
@vedfordev
Copy link
Contributor Author

@himeshr / @vinayvenu raised pull request please check once.

vedfordev added a commit to vedfordev/avni-webapp that referenced this issue Mar 4, 2024
himeshr added a commit that referenced this issue Mar 4, 2024
@github-project-automation github-project-automation bot moved this from New Issues to Done in Avni Product Mar 4, 2024
@himeshr himeshr moved this from Done to QA Ready in Avni Product Mar 4, 2024
@himeshr himeshr reopened this Mar 4, 2024
@github-project-automation github-project-automation bot moved this from QA Ready to Triaged in Avni Product Mar 4, 2024
@himeshr himeshr moved this from Triaged to QA Ready in Avni Product Mar 4, 2024
@himeshr
Copy link
Contributor

himeshr commented Mar 4, 2024

Test Cases

  • Users without sync concept value config
  • Users with coded sync concept value config (APFOdisha Users)
  • Users with Text sync concept value config (Goonj users)

@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Mar 6, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented Mar 7, 2024

  • Tried with goonj organisation on prerelease the sync attribute concept is not coming there it is visible same in the screen shot

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Mar 7, 2024
@vedfordev
Copy link
Contributor Author

@AchalaBelokar changes are not approved. Now I approved to staging. Moving card back to qa ready. check in staging.

@vedfordev vedfordev moved this from QA Failed to QA Ready in Avni Product Mar 7, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Mar 7, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Test cases review in Avni Product Mar 7, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented Mar 7, 2024

  • tested with goonj revamp the value is visible there
  • tested on rwbniti it is working fine there here coded concept is present
  • without sync attributes it is working
  • checked edit user
  • creating user with coded concepts
  • creating user with other text concept
  • edited coded concepts.

@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 8, 2024

@AchalaBelokar add the testcases related to other concept types that u mentioned already tested. Did you check the edit flow as well?

@mahalakshme mahalakshme moved this from Test cases review to QA Ready in Avni Product Mar 8, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Mar 8, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Test cases review in Avni Product Mar 8, 2024
@mahalakshme mahalakshme moved this from Test cases review to Test cases review with comments in Avni Product Apr 1, 2024
@AchalaBelokar AchalaBelokar moved this from Test cases review with comments to Done in Avni Product Apr 1, 2024
@mahalakshme mahalakshme moved this from Done to Code Review with Comments in Avni Product Apr 1, 2024
@mahalakshme mahalakshme removed the status in Avni Product Apr 1, 2024
@mahalakshme mahalakshme moved this to Test cases review with comments in Avni Product Apr 1, 2024
@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 1, 2024

@AchalaBelokar you have not yet added the test cases that u mentioned, test with text and numeric concepts if not tested - test edit , show, creating user

@AchalaBelokar AchalaBelokar moved this from Test cases review with comments to Done in Avni Product Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants