Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File preview failing for multi-select form element in data entry app #1325

Closed
petmongrels opened this issue Sep 6, 2024 · 3 comments
Closed

File preview failing for multi-select form element in data entry app #1325

petmongrels opened this issue Sep 6, 2024 · 3 comments
Assignees
@petmongrels

Comments

@petmongrels
Copy link
Contributor

petmongrels commented Sep 6, 2024 •
edited by mahalakshme
Loading

https://avni.freshdesk.com/a/tickets/4456

about the fix

only supporting one preview right now, as we have made a lot fixes around this in later releases.
changes should not be merged
@petmongrels petmongrels converted this from a draft issue Sep 6, 2024
@petmongrels petmongrels self-assigned this Sep 6, 2024
petmongrels added a commit that referenced this issue Sep 6, 2024
@petmongrels
#1325 - support one preview in case of multiple
473d4f3
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Sep 6, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to QA Ready in Avni Product Sep 6, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 10, 2024

QA Notes:

  • Fix stops app from breaking
  • File preview does not seem to have been modified in later releases so we could merge this
  • We should put in a proper product fix to display multiple files in the preview if present

@1t5j0y 1t5j0y moved this from In QA to Done in Avni Product Sep 10, 2024
@petmongrels
Copy link
Contributor Author

to be merged by with master

@petmongrels petmongrels moved this from Done to Ready in Avni Product Sep 11, 2024
@vinayvenu vinayvenu reopened this Sep 11, 2024
@github-project-automation github-project-automation bot moved this from Ready to Triaged in Avni Product Sep 11, 2024
@mahalakshme
Copy link
Contributor

@petmongrels I have added the above in release card, so will close this.

@github-project-automation github-project-automation bot moved this from Triaged to Done in Avni Product Sep 11, 2024
1t5j0y added a commit that referenced this issue Sep 12, 2024
@1t5j0y
#1329 | yarn.lock update after merging #1325 to master
d77837c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petmongrels petmongrels

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petmongrels @vinayvenu @mahalakshme @1t5j0y