Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEA] Show count results #1390

Closed
Tracked by #1596
mahalakshme opened this issue Dec 2, 2024 · 6 comments
Closed
Tracked by #1596

[DEA] Show count results #1390

mahalakshme opened this issue Dec 2, 2024 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Dec 2, 2024

https://avni.freshdesk.com/a/tickets/4791

Context:

  • Initially we were showing the number of pages. Removed it recently to reduce the impact on performance on DEA Search. This is to bring it back to show the count when users want it so that it doesn't necessarily affect the performance and considering this is a basic need.

AC:

  • UX for showing total number of pages in DEA:

DEA: ('Display count' checkbox is added)
Image

When count filter checked:
Image

  • 'Display count' should be shown in other languages based on what is selected in the Settings. To know the translations check here.

Old: Ignore

AC:

  • UX for showing total number of pages in Media Viewer and DEA: Click here
    - We need not show 1-10 of more than 10 in DEA. Instead just display left and right arrows along with the ability to change the number of search results per page in the centre. Towards the bottom right show the total number of results on click of the link.
    - Also show the total number of results in MediaViewer in the bottom right.
@mahalakshme mahalakshme converted this from a draft issue Dec 2, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Dec 3, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Dec 6, 2024
@mahalakshme mahalakshme added the good first issue Good for newcomers label Dec 6, 2024
@adamsanadi6 adamsanadi6 moved this from Ready to In Progress in Avni Product Dec 6, 2024
@adamsanadi6 adamsanadi6 self-assigned this Dec 6, 2024
@mahalakshme mahalakshme changed the title Show number of pages at bottom [DEA] Improve UX (Show number of pages and sort icon) Dec 6, 2024
@mahalakshme mahalakshme moved this from In Progress to In Analysis in Avni Product Dec 9, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 10, 2024
@mahalakshme mahalakshme changed the title [DEA] Improve UX (Show number of pages and sort icon) [DEA] Show count results Dec 10, 2024
@vedfordev vedfordev moved this from Ready to In Progress in Avni Product Dec 11, 2024
@vedfordev vedfordev assigned vedfordev and unassigned vedfordev Dec 11, 2024
@vedfordev vedfordev moved this from In Progress to Ready in Avni Product Dec 11, 2024
@vedfordev vedfordev moved this from Ready to In Progress in Avni Product Dec 12, 2024
@vedfordev vedfordev self-assigned this Dec 12, 2024
@vedfordev vedfordev removed the good first issue Good for newcomers label Dec 13, 2024
vedfordev added a commit to avniproject/avni-server that referenced this issue Dec 13, 2024
@vedfordev
Copy link
Contributor

Dea part is done. Media Service part is remaining

vedfordev added a commit that referenced this issue Dec 13, 2024
himeshr pushed a commit that referenced this issue Dec 13, 2024
(cherry picked from commit 956e199)
@mahalakshme
Copy link
Contributor Author

mahalakshme commented Dec 17, 2024

@vedfordev I will separate out the media part for later release. Moved it to Code Review Ready, let me know if you think otherwise.

@mahalakshme mahalakshme moved this from In Progress to Code Review Ready in Avni Product Dec 17, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Dec 17, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Dec 17, 2024
@dinesh2096
Copy link

  • In DEA we are getting the NaN instead of total count
  • And if we check or uncheck the checkbox it showing the total count but it expected if we uncheck the count should be hide.

Reference Image :

Image

@dinesh2096 dinesh2096 self-assigned this Dec 17, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to QA Failed in Avni Product Dec 17, 2024
@vedfordev vedfordev moved this from QA Failed to In Progress in Avni Product Dec 18, 2024
@vedfordev
Copy link
Contributor

@dinesh2096 seems like server changes are not deployed

response from https://prerelease.avniproject.org/web/searchAPI/v2

{"listOfRecords":[]}

@vedfordev vedfordev moved this from In Progress to In QA in Avni Product Dec 18, 2024
@dinesh2096
Copy link

Reference video for QA :

Click here to watch the video

@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Dec 18, 2024
@dinesh2096
Copy link

  • Tested the search without enabling the display count validated the performance and UI
  • Tested the search with enabling the display count validate the performance and total count is displayed
  • Tested by increased the count of the page and validate the count is refreshed in the UI and total count is displayed
  • Tested by enabling the include voided and display count validate the count is displayed.
  • Tested by navigating to the individual and coming back validate the count is still displayed.
  • Tested by applying combination of all the search filter and validate the count.
  • Tested by changing the subject types and validate the display count check box get unchecked.
  • Tested the display count with subject type doesnt have any data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants