Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side menu always displays #3059

Closed
4 of 11 tasks
jpawlyn opened this issue Jul 26, 2024 · 3 comments · Fixed by #3064
Closed
4 of 11 tasks

Side menu always displays #3059

jpawlyn opened this issue Jul 26, 2024 · 3 comments · Fixed by #3064
Assignees
@binarygit
Labels
Bug Something isn't working

Comments

@jpawlyn
Copy link
Contributor

jpawlyn commented Jul 26, 2024 •
edited
Loading

Describe the bug

On upgrading from Avo 3.10.7 to 3.10.8 or 3.10.9, the side menu on mobile view is always displaying when either a resources menu item or a record link is clicked.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Switch to a mobile view
  2. Click on a resources menu item

Expected behavior & Actual behavior

For Avo 3.10.7, when a resources menu or link is clicked on the mobile view, no side menu appears when the new page has been loaded. For Avo 3.10.8 and 3.10.9, the side menu is always displayed.

Models and resource files

System configuration

Avo version:
3.10.9

Rails version:
7.1.3.4

Ruby version:
3.3.4

License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Screen.Recording.2024-07-26.at.08.59.25.mov

Additional context

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@adrianthedev adrianthedev added the Bug Something isn't working label Jul 26, 2024
@adrianthedev
Copy link
Collaborator

Thanks for sending this in.
This might be related to #3041.

We'll have a look!

@adrianthedev adrianthedev moved this to Next up in Issues Jul 26, 2024
@adrianthedev
Copy link
Collaborator

adrianthedev commented Jul 26, 2024 •
edited
Loading

@G-Simpson would you be available to have a look at this?
Maybe there's a CSS-only version of fixing this bug.

@adrianthedev adrianthedev moved this from Next up to In Progress in Issues Jul 29, 2024
@binarygit binarygit mentioned this issue Jul 29, 2024
Merged
4 tasks
@binarygit binarygit moved this from In Progress to In Review in Issues Jul 29, 2024
@Paul-Bob Paul-Bob moved this from In Review to In Progress in Issues Jul 29, 2024
@binarygit binarygit moved this from In Progress to Done in Issues Jul 29, 2024
@binarygit binarygit moved this from Done to In Review in Issues Jul 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Issues Jul 29, 2024
@G-Simpson
Copy link
Contributor

@G-Simpson would you be available to have a look at this? Maybe there's a CSS-only version of fixing this bug.

Sorry I've been away for a few days. Glad to see it was resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binarygit binarygit

Labels
Bug Something isn't working
Projects
Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Side menu always displays binarygit/avo
4 participants
@jpawlyn @adrianthedev @binarygit @G-Simpson