Fix: Side menu always displays

[binarygit]

Description

This PR ensures that the correct cookie is set after a user toggles the sidebar

Fixes #3059

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

2024-07-29.14-10-08.mp4

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit 9d6c238 and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

Can we make it so on initial load (so no cookie was set) it's not visible?
Try it in incognito to see what I mean.

[adrianthedev]

The previous issue is fixed, but it does not behave correctly.
It's still open on subsequent navigation.

CleanShot.2024-07-29.at.13.50.30.mp4

[binarygit]

@adrianthedev
Could you look at my latest commit?

I preserved the old behaviour:

2024-07-29.20-18-24.mp4

However, when the page loads and the user hasn't toggled the sidebar yet, the sidebar "pops" open rather than "sliding out" because the js executes a little later than the css and the user can't see the transition. After this subsequent toggles do show the transition.

I'm not sure how to keep the sidebar hidden on mobile at first render and then also have it show the transition.

[Paul-Bob]

However, when the page loads and the user hasn't toggled the sidebar yet, the sidebar "pops" open rather than "sliding out" because the js executes a little later than the css and the user can't see the transition.

The CSS transitions are never getting executed.

The JS removes then adds sidebar-open very quickly and the browser doesn't have time to apply the transitions.

Let's force a reflow on it.