Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some cookies are misusing the recommended “SameSite“ attribute #3106

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Aug 8, 2024

Description

Fixes https://discord.com/channels/740892036978442260/1270822164345524316

Fixing a bug that was introduced here.

Some cookies are misusing the recommended “SameSite“ attribute was getting raised which led to some strange behaviors.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob requested a review from binarygit August 8, 2024 08:13
@github-actions github-actions bot added the Fix label Aug 8, 2024
Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit a0b20e5 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 738b031 into main Aug 8, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the fix/misusing_the_recommended_same_site_attribute branch August 8, 2024 09:13
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants