Changing the number of items per page fails

[filipegiusti]

Describe the bug

The per page links generated don't respect the current loaded resource.

And this causes changing the per page option to raise an unhandled exception or to show a "can't load has many association" error.

Reproduction repository for the bug

https://github.com/filipegiusti/per-page-bug

http://localhost:3000/avo/resources/coached_contacts/1

Steps to use in the reproduction repository

Steps to reproduce the behavior:

1. Add a Contact on http://localhost:3000/avo/resources/contacts/new
2. Add an Activity on http://localhost:3000/avo/resources/activities/new
3. Go to http://localhost:3000/avo/resources/coached_contacts/1 or to http://localhost:3000/avo/resources/coached_contacts/1/activities
4. Change the per page number of Activities
5. See error

Expected behavior & Actual behavior

The per page attribute should change and the items should display.

The actual behavior is the error "Failed to load has many field show activities frame".

System configuration

Avo version: 3.17.6
Rails version: 7.2.2.1
Ruby version: 3.3.1

License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Screenshots or screen recordings

Additional context

We do have both Resources::Contact and Resources::CoachedContact and the later uses self.model_class = Contact. In the same vein we have Resources::Activity and Resources::ContactActivity.

I was able to track down the issue to https://github.com/avo-hq/avo/blob/main/app/components/avo/paginator_component.rb#L15 the @parent_record is a Contact and the resource is a ContactActivity but the parent resource is a CoachedContact.

This wouldn't be so impactful to us if #2661 existed as we could put in sane defaults.

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)

[Paul-Bob]

I hope that as I've tracked down the bug it's enough that it doesn't need a reproduction repository but let me know otherwise.

Hi @filipegiusti,

A reproduction repository isn't necessary if the issue can be easily reproduced at main avo demo.

If that's the case, please provide the steps to reproduce the issue there.

We always need a clear way to replicate issues to ensure we focus on the correct fix.

If a reproduction repository is required, you can follow this quick guide:
How to create a reproduction repository.

It should only take a couple of minutes to set up.

Thank you!

[filipegiusti]

@Paul-Bob I've updated with a reproduction repository, let me know if you need anything else from me.

[Paul-Bob]

Thank for the update @filipegiusti

I have reproduced the issue, identified the problem, and submitted a PR with a fix. The reproduction repository was very helpful.

[filipegiusti]

@Paul-Bob thank you very much.