Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change_items_per_page_url on paginator component #3675

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3667

Fixing change_items_per_page_url by using the parent resource's route key instead of the parent model's route key.

This is useful when the parent resource uses self.model_class and its route key differs from that of the parent model.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Feb 19, 2025
Copy link

codeclimate bot commented Feb 19, 2025

Code Climate has analyzed commit c4582f7 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 94d1ed9 into main Feb 19, 2025
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/paginator_change_items_per_page_url branch February 19, 2025 12:09
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the number of items per page fails
1 participant