-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor actions controller #2703
Conversation
Code Climate has analyzed commit 6ecaf15 and detected 0 issues on this pull request. View more on Code Climate. |
lib/avo/configuration.rb
Outdated
@@ -160,7 +162,9 @@ def license=(value) | |||
def license | |||
gems = Gem::Specification.map {|gem| gem.name} | |||
|
|||
@license ||= if gems.include?("avo-advanced") | |||
@license ||= if gems.include?("avo-audits") | |||
"enterprise" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you consider moving the audit feature to the advanced plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yorsant.
Apologies for the late reply.
The audit logging feature is, generally speaking, an enterprise feature.
As much as we want to give features away or make them cheaper, we can't do that. It takes a lot of time and effort to build Avo.
We love the self-serve product (Pro, Advanced) but the reality is that we can't survive and improve our business without having some big customers. We've heard from customers that they saved tens and even hundreds of thousands of dollars by using Avo and that they would like to pay more.
If we don't have any Enterprise features, we can't sell Enterprise subscriptions.
This all comes back to us being able to build a robust business and being able to ship more value through our products.
Thanks for asking the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW you can build audit log yourself using papertrail and avo resources.
This PR has been marked as stale because there was no activity for the past 15 days. |
This PR has been merged into Please check the release guide for more information. |
Description
Related to #1328
Refactor actions controller
Checklist: