Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: floating resource controls in table rows #3280

Merged
merged 15 commits into from
Jan 28, 2025

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Sep 29, 2024

Description

This PR introduces breaking changes to the way row controls are configured in Avo. The previous configuration options have been replaced with a new, more flexible configuration structure.

Breaking Changes

  • Global Configuration:

    # Before
    config.resource_controls_placement = :left
    
    # After
    config.resource_row_controls_config = {
      placement: :left,
    }.freeze
  • Resource-Specific Configuration:

    # Before
    self.controls_placement = :left
    
    # After
    self.row_controls_config = {
      placement: :left,
    }.freeze

The new configuration structure allows for additional options float and show_on_hover to enhance the flexibility of row controls.

Migration Notes

All instances of the deprecated configuration must be updated to the new structure. Please refer to the updated documentation for detailed guidance.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

CleanShot 2024-09-29 at 12 06 33

Copy link

codeclimate bot commented Sep 29, 2024

Code Climate has analyzed commit bb497ac and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@Paul-Bob
Copy link
Contributor

Random thought: What if the floating resource controls only appear on hover, similar to how they work in Gmail?

@adrianthedev
Copy link
Collaborator Author

Yup. Great idea. This PR would enable that!

@Paul-Bob Paul-Bob changed the title refactor: floating resource controls in table rows enhancement: floating resource controls in table rows Jan 27, 2025
@Paul-Bob Paul-Bob marked this pull request as ready for review January 27, 2025 15:13
@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved and removed Refactor Stale exempt labels Jan 28, 2025
@Paul-Bob Paul-Bob merged commit 34a8589 into main Jan 28, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the refactor/floating-resource-controls branch January 28, 2025 17:20
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants