Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tags value on select mode #3576

Merged
merged 7 commits into from
Jan 9, 2025
Merged

fix: tags value on select mode #3576

merged 7 commits into from
Jan 9, 2025

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jan 8, 2025

Description

Fixes the handling of tags value when used with mode: :select.

The internal logic of the tags components assumes that its value is always an array.
However, when using mode: :select, the value may be stored in a string-backed database column.
This mismatch causes issues with the tags components.

This fix ensures that the tags value is always coerced into an array.
Specifically, for mode: :select, the string value is converted into a single-element array.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Jan 8, 2025
Copy link

codeclimate bot commented Jan 8, 2025

Code Climate has analyzed commit eae5dbe and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Jan 8, 2025
@Paul-Bob Paul-Bob merged commit ca1d2c6 into main Jan 9, 2025
16 of 19 checks passed
@Paul-Bob Paul-Bob deleted the fix/tags_value branch January 9, 2025 08:43
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@pjmuller pjmuller mentioned this pull request Jan 21, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant