Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: markdown field (easy_mde replacement) #3584

Closed
wants to merge 14 commits into from

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Jan 14, 2025

Description

Fixes #3378

CleanShot 2025-01-14 at 15 43 07

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://docs.avohq.io/3.0/fields/markdown.html
  • I have added tests that prove my fix is effective or that my feature works
  • fix i18n tasks
  • check if redcarpet is installed when trying to use the field

Screenshots & recording

Manual review steps

  1. Go to a project
  2. test the field in description
  • write
  • preview
  • styles
  • paste a file with cmd+V
  • drop a file over the field

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jan 14, 2025

Code Climate has analyzed commit 05e719e and detected 0 issues on this pull request.

View more on Code Climate.

lib/avo/fields/easy_mde_field.rb Outdated Show resolved Hide resolved
lib/avo/fields/easy_mde_field.rb Outdated Show resolved Hide resolved
@adrianthedev adrianthedev marked this pull request as draft January 19, 2025 12:49
@adrianthedev
Copy link
Collaborator Author

Let's wait a bit with this one. I have an idea.

@Paul-Bob Paul-Bob assigned adrianthedev and unassigned Paul-Bob Jan 20, 2025
@adrianthedev
Copy link
Collaborator Author

Closing in favor of https://github.com/avo-hq/marksmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GitHub-style Markdown editor
2 participants