Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass wrapper data on heading field #3619

Merged

Conversation

Paul-Bob
Copy link
Contributor

Description

This PR ensures that wrapper data is correctly assigned to heading fields.

field :title, as: :heading, html: -> {
  edit do
    wrapper do
      classes do
        "hidden"
      end
      # This was not assigned before this PR
      data do
        {
          "some-controller-target": "titleHeading"
        }
      end
    end
  end
}

@Paul-Bob Paul-Bob self-assigned this Jan 30, 2025
@github-actions github-actions bot added the Fix label Jan 30, 2025
Copy link

codeclimate bot commented Jan 30, 2025

Code Climate has analyzed commit ec0e505 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 5e41f9a into main Jan 30, 2025
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/pass_wrapper_data_from_field_html_on_heading_field branch January 30, 2025 11:15
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant