Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fetch heroicons from avo-heroicons #3671

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3657

Removes all Heroicons SVGs and fetches them from avo-heroicons, preventing the need to precompile SVGs each time.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Feb 17, 2025
Copy link

codeclimate bot commented Feb 17, 2025

Code Climate has analyzed commit 8355223 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 83f6da0 into main Feb 17, 2025
19 of 20 checks passed
@Paul-Bob Paul-Bob deleted the refactor/avo-heroicons branch February 17, 2025 12:49
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With propshaft this gem creates a lot of assets during precompile
1 participant