Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task cancelation on job timeout #5530

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Task cancelation on job timeout #5530

merged 1 commit into from
Dec 2, 2022

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Nov 28, 2022

This commit adds a mechanism for terminating running tasks after the job reaches its timeout.

Reference: #5295
Signed-off-by: Jan Richter jarichte@redhat.com

@richtja richtja added this to the #100 (the 100) milestone Nov 28, 2022
@richtja richtja self-assigned this Nov 28, 2022
@richtja richtja linked an issue Nov 28, 2022 that may be closed by this pull request
job-timeout not working with nrunner #5295
Closed
@richtja richtja marked this pull request as draft November 28, 2022 15:10
@richtja richtja marked this pull request as ready for review November 29, 2022 10:46
clebergnu
clebergnu reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richtja, this looks quite good, but I have a pending question about time.monotonic(). Thanks.

avocado/core/task/statemachine.py Show resolved Hide resolved
avocado/core/task/statemachine.py Show resolved Hide resolved
@richtja
Task cancelation on job timeout
f49ec19 
This commit adds a mechanism for terminating running tasks after the job
reaches its timeout.

Reference: avocado-framework#5295
Signed-off-by: Jan Richter <jarichte@redhat.com>
@richtja richtja requested a review from clebergnu December 2, 2022 10:43
clebergnu
clebergnu approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit 6c9a2ed into avocado-framework:master Dec 2, 2022
@richtja richtja deleted the job_timeout branch December 2, 2022 15:24
@clebergnu clebergnu mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clebergnu clebergnu clebergnu approved these changes

@beraldoleal beraldoleal Awaiting requested review from beraldoleal

Assignees

@richtja richtja

Labels
bug customer:Libvirt
Projects
None yet
Milestone
#100 (the 100)
Development

Successfully merging this pull request may close these issues.

job-timeout not working with nrunner
2 participants
@richtja @clebergnu