Remove special egg handling for 103.0 #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 103.0 was released, it was necessary to conditionally allow failures for the 103.0 eggs. Not any longer. Fixes: avocado-framework#5791 Signed-off-by: Cleber Rosa <crosa@redhat.com>
The fetching of the regular eggs is not being protected for error conditions. Also, the signaling of error conditions as exit status is currently broken. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Both Avocado and setuptools eggs are needed to run Avocado from eggs. Let's expand the scripts to also include setuptools. Signed-off-by: Cleber Rosa <crosa@redhat.com>
richtja
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
contrib/scripts/avocado-fetch-eggs.pyfile, as can be seen in PR #5789, has a TODO to have the special handling after 103.0 is released.This is a removal of that special handling, and a couple of extra improvements.