Try catch in post-install script #374

logason · 2023-10-12T23:44:19Z

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205713603587404
- https://app.asana.com/0/0/1205678994166086

hugihlynsson · 2023-10-16T09:29:00Z

cli.ts

-        }
-      });
+      try {
+        Avo.cliInstalled({


I was a bit surprised at first that this doesn't have an await but then I guess we're already .catch-ing that promise. I guess we're try-catching issues that happen before the called function manages to return the Promise?

Probably yes, at least something is causing it to fail for people 🤔

logason added 2 commits October 12, 2023 23:41

Try catch in post-install script

bfec6a6

Prep release

b97c2fd

logason requested review from a team and hugihlynsson and removed request for a team October 12, 2023 23:44

Fix formatting

a1e5421

logason requested a review from bjornj12 October 13, 2023 12:30

hugihlynsson approved these changes Oct 16, 2023

View reviewed changes

logason merged commit 30b26b5 into main Oct 16, 2023
4 checks passed

logason deleted the try-catch-post-install branch October 16, 2023 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try catch in post-install script #374

Try catch in post-install script #374

logason commented Oct 12, 2023 •

edited

Loading

hugihlynsson Oct 16, 2023

logason Oct 16, 2023

Try catch in post-install script #374

Try catch in post-install script #374

Conversation

logason commented Oct 12, 2023 • edited Loading

hugihlynsson Oct 16, 2023

Choose a reason for hiding this comment

logason Oct 16, 2023

Choose a reason for hiding this comment

logason commented Oct 12, 2023 •

edited

Loading