This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
To use firebase in react native the dom api dependency needed to be removed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://firebase.google.com/docs/reference/js/firebase.storage.Reference this basically removes the dependency on dom and allows this to be used on react native
arnarthor
suggested changes
Jan 2, 2018
| "firebase": "^4.4.0" | ||
| "bs-platform": "^2.1.0", | ||
| "firebase": "^4.4.0", | ||
| "global": "^4.3.2" |
| }, | ||
| "dependencies": { | ||
| "firebase": "^4.4.0" | ||
| "bs-platform": "^2.1.0", |
There was a problem hiding this comment.
This should be a peer dependency and dev depedency, but not a depedency. It's a problem with packages being dependencies between projcets.
| }, | ||
| "keywords": [ | ||
| "BuckleScript" | ||
| ], | ||
| "license": "MIT", | ||
| "peerDependencies": { | ||
| "bs-platform": "^2.0.0", | ||
| "bs-webapi": "git+https://github.com/viskahq/bs-webapi-incubator.git" | ||
| "bs-platform": "^2.0.0" |
There was a problem hiding this comment.
Since the depedency (which should be dev) is 2.1.0 this should be that as well
| @@ -109,7 +107,7 @@ module Storage = { | |||
| [@bs.send] external path : (t, ~path: string) => t = ""; | |||
| [@bs.send] | |||
| external put : | |||
| (t, ~data: Window.File.t, ~metadata: Js.t('a)=?, unit) => Js.Promise.t(UploadTask.t) = | |||
| (t, ~data: Js.Array.t(int), ~metadata: Js.t('a)=?, unit) => Js.Promise.t(UploadTask.t) = | |||
There was a problem hiding this comment.
Maybe just have it 'a since Js.Array of int is definitely not correct in the browser.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase api in javascript has no such dependency either, it seems to be pretty platform agnostic.
Please test if this change will compile for you.
I'm following the firebase spec which says that the put data should be an array of ints, however I can imagine this will break stuff for you. Please tell me how to fix this properly then.
I'm not sure how you use this.