Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross referencing stakeholders in workflow docs #1310

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cross referencing stakeholders in workflow docs #1310

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dac3caf
Cross referencing stakeholders in workflow docs
klaraavo Oct 17, 2024
80bb0e1
Update review.mdx
klaraavo Oct 17, 2024
1053d42
Update pages/workflow/review.mdx
hugihlynsson Oct 17, 2024
af3d428
Update pages/workflow/review.mdx
hugihlynsson Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pages/workflow/review.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import { Callout } from 'nextra/components';

# Review suggestions in Avo

## Ask for a review

_Role: Product, Data, Engineering. See more below_

Once you have drafted changes to your tracking plan we recommend asking your teammates to review your suggested changes.
Once you have drafted changes to your tracking plan we recommend asking your teammates and any [impacted stakeholders](data-design/guides/managing-changes-impacting-multiple-stakeholders) to review your suggested changes. To do this, click "View changes" in the branch header to navigate to the review screen.
hugihlynsson marked this conversation as resolved.
Show resolved Hide resolved

**Who should be asked for a review?**
We typically see three types of reviewers:
Expand All @@ -20,6 +18,8 @@ We typically see three types of reviewers:
- **Data team:** Someone who validates that the changes made are according to the data standard of your company
- **Engineering team:** The folks who will implement the suggested changes. If the changes made affect multiple sources (e.g. iOS, Android, Web, backend) we recommend to get reviews from the teams working on each source

Additionally, if your changes impact [stakeholder domains](data-design/avo-tracking-plan/stakeholder-domains) in your organization that you are not a member of, we recommend pulling someone from the respective domain in to review the changes. See our guide on [managing changes impacting multiple stakeholders](data-design/guides/managing-changes-impacting-multiple-stakeholders).
hugihlynsson marked this conversation as resolved.
Show resolved Hide resolved

**How to ask for a review?**
The first step is to mark the branch as “Ready for review”. This is done at the bottom of the review screen as seen on the screenshot below.

Expand Down
Loading