Avrdude terminal history broken on macOS

[MCUdude]

I just stumbled over this. When building with make, the Avrdude terminal history is broken on macOS.
I've narrowed it down to the following commit by @mcuee: 6595f53

$ ./avrdude -cusbasp -patmega1284p -t

avrdude: AVR device initialized and ready to accept instructions
avrdude: device signature = 0x1e9705 (probably m1284p)
avrdude> read eeprom

Reading | ################################################## | 100% 0.07 s 

0000  48 65 6c 6c 6f 20 57 6f  72 6c 64 00 ff ff ff ff  |Hello World.....|
0010  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0020  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0030  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0040  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0050  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0060  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0070  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0080  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
0090  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00a0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00b0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00c0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00d0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00e0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
00f0  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|

avrdude> ^[[A^[[A^[[A^[[A^C

[mcuee]

Hmm, that is stange. The change is supposed to change nothing but the prompt only. Let me check later.

[mcuee]

Strange, git main is broken, even with CMake build. 7.1 release is okay.

Sorry this is a false alarm. I have delete the git repo and try again, it works with CMake.

[mcuee]

@MCUdude

Indeed you are right, revert that PR #1280 will indeed fix the issue. I think configure.ac is pretty broken and we may have to really forget about it and only use CMake down the road.

mcuee@mcuees-Mac-mini avrdude_main % git diff
diff --git a/src/configure.ac b/src/configure.ac
index 4f35c1c..6470f88 100644
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -83,7 +83,7 @@ AC_CHECK_LIB([ws2_32], [WSAStartup])
 
 AC_CHECK_LIB([termcap], [tputs])
 AC_CHECK_LIB([ncurses], [tputs])
-AC_CHECK_LIB([readline], [readline], [have_readline=yes])
+AC_CHECK_LIB([readline], [readline])
 AH_TEMPLATE([HAVE_LIBELF],
             [Define if ELF support is enabled via libelf])
 AC_CHECK_LIB([elf], [elf_getshdrstrndx], [have_libelf=yes])

[mcuee]

@MCUdude

I have created PR #1297 to revert the change of PR #1280.

[mcuee]

@MCUdude

I have merged #1297 to fix this issue.