Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml to revert PR #1513 #1516

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Oct 13, 2023

PR #1513 (Add GNU Readline to mingw github action) brings in undesired dependency of libwinpthread-1.dll to the mingw32/mingw64 binaries.

This PR reverts PR#1513.

PR avrdudes#1513 (Add GNU readline to mingw github action) brings in undesired dependency of libwinpthread-1.dll to the mingw32/mingw64 binaries.
@mcuee
Copy link
Collaborator Author

mcuee commented Oct 13, 2023

With PR #1513, github created mingw64 binary with undesired dependancy.

$ ldd avrdude.exe
        ntdll.dll => /c/WINDOWS/SYSTEM32/ntdll.dll (0x7ff817710000)
        KERNEL32.DLL => /c/WINDOWS/System32/KERNEL32.DLL (0x7ff816ce0000)
        KERNELBASE.dll => /c/WINDOWS/System32/KERNELBASE.dll (0x7ff8152f0000)
        ADVAPI32.dll => /c/WINDOWS/System32/ADVAPI32.dll (0x7ff816b00000)
        msvcrt.dll => /c/WINDOWS/System32/msvcrt.dll (0x7ff815f30000)
        sechost.dll => /c/WINDOWS/System32/sechost.dll (0x7ff816390000)
        RPCRT4.dll => /c/WINDOWS/System32/RPCRT4.dll (0x7ff816bb0000)
        SETUPAPI.dll => /c/WINDOWS/System32/SETUPAPI.dll (0x7ff816e50000)
        HID.DLL => /c/WINDOWS/SYSTEM32/HID.DLL (0x7ff812270000)
        cfgmgr32.dll => /c/WINDOWS/System32/cfgmgr32.dll (0x7ff815720000)
        libwinpthread-1.dll => /mingw64/bin/libwinpthread-1.dll (0x7ff80e870000)
        ucrtbase.dll => /c/WINDOWS/System32/ucrtbase.dll (0x7ff815140000)
        bcrypt.dll => /c/WINDOWS/System32/bcrypt.dll (0x7ff814df0000)
        USER32.dll => /c/WINDOWS/System32/USER32.dll (0x7ff816430000)
        win32u.dll => /c/WINDOWS/System32/win32u.dll (0x7ff8155f0000)
        GDI32.dll => /c/WINDOWS/System32/GDI32.dll (0x7ff816a00000)
        gdi32full.dll => /c/WINDOWS/System32/gdi32full.dll (0x7ff814e20000)
        msvcp_win.dll => /c/WINDOWS/System32/msvcp_win.dll (0x7ff814f40000)
        WS2_32.dll => /c/WINDOWS/System32/WS2_32.dll (0x7ff816a30000)

Now it should be okay.

The problem is that we do not have GNU Readline support for mingw32/mingw64.

$ ldd avrdude.exe
        ntdll.dll => /c/WINDOWS/SYSTEM32/ntdll.dll (0x7ff817710000)
        KERNEL32.DLL => /c/WINDOWS/System32/KERNEL32.DLL (0x7ff816ce0000)
        KERNELBASE.dll => /c/WINDOWS/System32/KERNELBASE.dll (0x7ff8152f0000)
        ADVAPI32.dll => /c/WINDOWS/System32/ADVAPI32.dll (0x7ff816b00000)
        msvcrt.dll => /c/WINDOWS/System32/msvcrt.dll (0x7ff815f30000)
        sechost.dll => /c/WINDOWS/System32/sechost.dll (0x7ff816390000)
        RPCRT4.dll => /c/WINDOWS/System32/RPCRT4.dll (0x7ff816bb0000)
        SETUPAPI.dll => /c/WINDOWS/System32/SETUPAPI.dll (0x7ff816e50000)
        cfgmgr32.dll => /c/WINDOWS/System32/cfgmgr32.dll (0x7ff815720000)
        HID.DLL => /c/WINDOWS/SYSTEM32/HID.DLL (0x7ff812270000)
        ucrtbase.dll => /c/WINDOWS/System32/ucrtbase.dll (0x7ff815140000)
        bcrypt.dll => /c/WINDOWS/System32/bcrypt.dll (0x7ff814df0000)
        WS2_32.dll => /c/WINDOWS/System32/WS2_32.dll (0x7ff816a30000)

@mcuee mcuee added the bug Something isn't working label Oct 13, 2023
@mcuee
Copy link
Collaborator Author

mcuee commented Oct 13, 2023

Lesson learned to me --> do not touch MinGW GNU Readline support now.

Previous attempt: (not merged)

Better approach is to have the following enhancement without using GNU Readine.

Previous failed attempts -- PRs which have to be reverted

@mcuee mcuee merged commit 331d46f into avrdudes:main Oct 13, 2023
10 checks passed
@mcuee mcuee deleted the revert_pr_1513 branch October 13, 2023 04:09
@mcuee
Copy link
Collaborator Author

mcuee commented Oct 13, 2023

Strange thing is that there is no such issue in my system.

$ ldd avrdude_55853eb.exe
        ntdll.dll => /c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffa6afd0000)
        KERNEL32.DLL => /c/WINDOWS/System32/KERNEL32.DLL (0x7ffa6ae30000)
        KERNELBASE.dll => /c/WINDOWS/System32/KERNELBASE.dll (0x7ffa68350000)
        ADVAPI32.dll => /c/WINDOWS/System32/ADVAPI32.dll (0x7ffa695d0000)
        msvcrt.dll => /c/WINDOWS/System32/msvcrt.dll (0x7ffa69520000)
        sechost.dll => /c/WINDOWS/System32/sechost.dll (0x7ffa6ace0000)
        RPCRT4.dll => /c/WINDOWS/System32/RPCRT4.dll (0x7ffa691b0000)
        SETUPAPI.dll => /c/WINDOWS/System32/SETUPAPI.dll (0x7ffa68d30000)
        USER32.dll => /c/WINDOWS/System32/USER32.dll (0x7ffa697d0000)
        win32u.dll => /c/WINDOWS/System32/win32u.dll (0x7ffa68990000)
        HID.DLL => /c/WINDOWS/SYSTEM32/HID.DLL (0x7ffa66b60000)
        GDI32.dll => /c/WINDOWS/System32/GDI32.dll (0x7ffa6ae00000)
        gdi32full.dll => /c/WINDOWS/System32/gdi32full.dll (0x7ffa68870000)
        msvcp_win.dll => /c/WINDOWS/System32/msvcp_win.dll (0x7ffa689c0000)
        ucrtbase.dll => /c/WINDOWS/System32/ucrtbase.dll (0x7ffa68c10000)
        WS2_32.dll => /c/WINDOWS/System32/WS2_32.dll (0x7ffa6abb0000)
        cfgmgr32.DLL => /c/WINDOWS/SYSTEM32/cfgmgr32.DLL (0x7ffa67f50000)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant