-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build.yml to revert PR #1513 #1516
Conversation
PR avrdudes#1513 (Add GNU readline to mingw github action) brings in undesired dependency of libwinpthread-1.dll to the mingw32/mingw64 binaries.
With PR #1513, github created mingw64 binary with undesired dependancy.
Now it should be okay. The problem is that we do not have GNU Readline support for mingw32/mingw64.
|
Lesson learned to me --> do not touch MinGW GNU Readline support now. Previous attempt: (not merged) Better approach is to have the following enhancement without using GNU Readine. Previous failed attempts -- PRs which have to be reverted |
Strange thing is that there is no such issue in my system.
|
PR #1513 (Add GNU Readline to mingw github action) brings in undesired dependency of libwinpthread-1.dll to the mingw32/mingw64 binaries.
This PR reverts PR#1513.