Added missing RTS/DTR management feature to serialupdi programmer #811
Conversation
|
Don't mind the failed msvc builds. Chocolatey seems to have issues (again!)... |
|
@dbuchwald there are some tabs in serialupdi.c that probably should be replaced by spaces. Other than this, I've tested it and it's working perfectly. Thank you! |
src/serialupdi.c
Outdated
| for (ln = lfirst(extparms); ln; ln = lnext(ln)) { | ||
| extended_param = ldata(ln); | ||
|
|
||
| if (sscanf(extended_param, "rtsdtr=%4s", rts_mode) == 1) { |
There was a problem hiding this comment.
@dbuchwald can you replace the tabs with spaces on line 948, 957 and 958?
Thanks!
|
Done. Sorry for the delay, got infected with COVID-19 and spent last couple of days on the edge of reality. Seems like I might be coming back though. |
No worries! I hope you recover quickly and don't have any long-term effects. I've somehow managed to not be infected yet, but the statistics tell me there's just a matter of time before it happens. @dl8dtl do you have a comment, or is it all good and can be merged? I'm going to use this on a programmer I've recently designed that will automatically switch between UPDI and UART mode based on this signal.
|
Only reason for not already merging it last night was that I wanted to copy&paste Dawid's documentation about the extended parameter handling over to |
|
Great, thanks! |
Hello, this PR contains all the additional changes to SerialUPDI programmer, enabling forcing DTR/RTS lines low/high during UPDI programming session. This could be used by dedicated hardware to indicate UPDI operation.
Documentation about extra parameters has also been updated.