-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos nonstandard baudrates #898
Conversation
Alas, MacOS doesn't handle nonstandard baud rates like other systems in regular tcsetattr() calls. Instead, they invented a new ioctl (IOSSIOSPEED). So, if we notice we are going to configure a nonstandard rate on MacOS, issue that ioctl after configuring everything else using tcsetattr().
Got accidentally committed.
Thanks for the PR, I can confirm that it works properly on my machine too (macOS 10.14) This is how it currently looks like:
It would be nice if it perhaps looked something like this instead:
BTW, the last commit could be dropped if you rebase your first commit. Adding something to a file and then removing the same code in another commit isn't preferable. |
Should this be applied to serbb_posix.c as well? |
@dl8dtl would be great if you could clarify. I've never used a serial bit-banging programmer myself, so I don't really know. |
As serbb* abuses the serial connection to perform bit-banging, I don't think arbitrary baudrates are of concern there. |
Supposed to fix issue #771