Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove elements appended to body in ngf-select on $destroy #1

Merged
merged 1 commit into from
Mar 7, 2018
Merged

fix: remove elements appended to body in ngf-select on $destroy #1

merged 1 commit into from
Mar 7, 2018

Commits on Mar 1, 2018

  1. fix: remove elements appended to body in ngf-select on $destroy 

    If the directive is added to something other than a file input, it adds
file input elements to the document body. Since these are outside of the
element the directive is applied to, they aren't automatically removed at
the end of its life.

The cleanup code for these elements already existed, but it was only being called
once when the directive was first applied, and wasn't doing anything. Now it
will be called on $destroy, and the file elements are correctly removed
    @ciaran-phillips
    ciaran-phillips committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    72db89b View commit details
    Browse the repository at this point in the history