-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance bottleneck at RecordNaming #151
Comments
Thanks for the benchmark. Can you put at least a screenshot of visualvm of CPU Time tab, or at most the file ? Also with source showing the benchmark if possible We know that there is still reflection that could be replaced, and a lot of re-computation on some cases. |
No problem, I uploaded the src and a screen shot here |
Thanks. I'll try to fix this |
I'm currently working on #148 that should improve the performances, I'll let you informed |
A huge performance improvement is planned for version 2. See #160 (comment) |
Duplicate of #199 |
FYI @twinprime I just move your project to avro4k to allow us benchmarking easily for the next releases, thanks for the codebase. See #208 |
Hi, I am not sure if this is a known problem.
I was doing a simple benchmark of Avro4k and discovered that when Unions are involved, e.g. a sealed interface, a lot of CPU time (like 30% for my case) is spent on
RecordNaming.invoke(String, List<Annotation>, NamingStrategy)
. I used VisualVM to verify.This is one of the thing that makes Avro4K much slower than jackson-dataformat-avro. Its 2-3x slower for my test case.
The text was updated successfully, but these errors were encountered: