Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Schemas for classes #159

Closed
thake opened this issue Aug 29, 2023 · 2 comments · Fixed by #190
Closed

Cache Schemas for classes #159

thake opened this issue Aug 29, 2023 · 2 comments · Fixed by #190
Labels
enhancement New feature or request
Milestone
Version 2

Comments

@thake
Copy link
Member

thake commented Aug 29, 2023

Add caching for the deducted Avro schemas to the library itself. The implementation of the cache must be thread-safe. A possible JVM-dependent way would be to use ClassValue as it is implemented in Avro's ClassValueCache.

Preferrable, the implementation should not depend on JVM specifics so that making this library multiplatform in the future is easier.
@thake thake mentioned this issue Aug 29, 2023
Open
@Chuckame Chuckame added the enhancement New feature or request label Sep 2, 2023
@thake thake added this to the Version 2 milestone Jan 21, 2024
@Chuckame Chuckame mentioned this issue Jan 22, 2024
Closed
14 tasks
@Chuckame Chuckame mentioned this issue Apr 14, 2024
Merged
@Chuckame
Copy link
Contributor

Done in #190

@Chuckame Chuckame linked a pull request May 22, 2024 that will close this issue
feat: revamp the schema generation #190
Merged
@Chuckame Chuckame reopened this May 22, 2024
@Chuckame
Copy link
Contributor

Released in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2
Development

Successfully merging a pull request may close this issue.

feat: revamp the schema generation Chuckame/avro4k
2 participants
@thake @Chuckame