Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 Support #13

Open
Oisota opened this issue Jul 26, 2022 · 2 comments
Open

Django 4.0 Support #13

Oisota opened this issue Jul 26, 2022 · 2 comments

Comments

@Oisota
Copy link

Oisota commented Jul 26, 2022

I ran into import errors when upgrading a project to Django 4.0. This line specifically:

from django.utils.translation import ugettext_lazy as _

This function has been removed in the latest version of Django. Is Django 4.0 support being worked on? If not, I'd be happy to work on it and submit a PR.

@avryhof
Copy link
Owner

avryhof commented Aug 9, 2022

I haven't done any Django 4.x work on this yet. I originally assumed we would need to wait for CMS 4.0 for Django 4 support, but it looks like it's in 3.11.

I've only just started moving projects up.

The short fix for that import is

from django.utils.translation import gettext_lazy as _

But, I assume there will be other updates that need to be made.

If you want to submit a PR, it will be gladly accepted.

@avryhof
Copy link
Owner

avryhof commented Aug 9, 2022

I took some time tonight to make sure everything imports from the right place.

See the django4 branch - https://github.com/avryhof/djangocms-forms/tree/django4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants