-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Django version to 4.2 #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting.
Also, I only just noticed that the original fork recently begun Django 4 updates (avryhof/djangocms-forms#13).
Comparisons:
- src. fork: avryhof/djangocms-forms@master...django4
- TACC fork TACC/djangocms-forms@master...compat/django4
pyproject.toml
Outdated
djangocms-forms-maintained = { git = "https://github.com/avryhof/djangocms-forms", rev = "d8a69efd2f447ee2f940c7b6f5b8b088c9cb79ed" } | ||
djangocms-forms-maintained = { git = "https://github.com/TACC/djangocms-forms", rev = "95489d535b8e03c98fcbf9a3d848f1139c896241" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need the TACC fork, because the original fork has similar (and more) updates for Django 4. Excellent work though. The work of both is similar.
P.S. I prefer your use of as
when importing to make a cleaner diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original fork's dajngo4
branch has no PR, and no Issue. Gross. Also it is 63 commits ahead of upstream, while its master
branch is 64 commits ahead. That's just weird. At least TACC's version is a commit on master. So, we stick with TACC, sure.
Only oddity of sticking with TACC is that the trail is unexpectedly long:
@jarosenb How about removing jarosenb
link in the chain? Or make PR to avryhof/djangocms-forms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Bootstrap revision worries me. I cannot find a paper trail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-review notes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Issues:
-
Form submission failure. This is being investigated (private link). -
Updatedjamgo-admin-style
to latest to fix UI bugs (source). -
Failure to create page on new local setup.
This should fix admin ui bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMS test went well. See (internal document) TUP Testing Session Django 4.2 Update - WMA.
This reverts commit e20c1c9.
Overview
Bump Django version to 4.2 and fix compatibility issues.
This uses a new fork of djangocms-forms that updates imports to deal with Django 4 deprecations: https://github.com/TACC/djangocms-forms
Related
Testing
Notes
Repo Maintainer Notes