Manage buffer with yaml in OCaml part of ocaml-yaml #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when a string with YAML was passed to yaml_parser_set_input_string, which would only store a pointer to it (not a copy). The temporary buffer, created by the FFI from string on calling this function was freed, and later overwritten - before being parsed by YAML parser. This changes the signature of yaml_parser_set_input_string to accept char ptr, and the char array is stored in parser type structure as long as is needed for parsing.
avsm
reviewed
Feb 7, 2020
There was a problem hiding this comment.
Excellent debugging and fix. Thanks for this @marcinkoziej!
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Feb 7, 2020
CHANGES: * Fix a memory unsoundness issue with larger files in the bindings to libyaml, which fixes spurious errors when parsing larger YAML files (avsm/ocaml-yaml#35 marcinkoziej) * Expose more information about error locations while parsing a Yaml file (avsm/ocaml-yaml#34 @marcinkoziej) * Add test for a large Yaml file (avsm/ocaml-yaml#30 @pmonson711) * Bump size of internal serialisation buffer in `to_string` to 64KB from 16KB (@avsm). * Switch CI to GitHub Actions (@avsm) * Depend on dune-configurator in the build to be compatible with dune 2.0 and higher (@avsm)
mgree
pushed a commit
to mgree/opam-repository
that referenced
this pull request
Feb 19, 2020
CHANGES: * Fix a memory unsoundness issue with larger files in the bindings to libyaml, which fixes spurious errors when parsing larger YAML files (avsm/ocaml-yaml#35 marcinkoziej) * Expose more information about error locations while parsing a Yaml file (avsm/ocaml-yaml#34 @marcinkoziej) * Add test for a large Yaml file (avsm/ocaml-yaml#30 @pmonson711) * Bump size of internal serialisation buffer in `to_string` to 64KB from 16KB (@avsm). * Switch CI to GitHub Actions (@avsm) * Depend on dune-configurator in the build to be compatible with dune 2.0 and higher (@avsm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #17 and #33 which result from a bug in passing input buffer to yaml parser.
When a string with yaml text is passed to
yaml_parser_set_input_string, it only stores a pointer to it (not acopy). The temporary buffer, created by the FFI from string on calling this
function is freed, and later overwritten - before being parsed by YAML parser. The corrupted input buffer makes the parsing fail.
This changes the signature of yaml_parser_set_input_string to accept char ptr,
and the char array is stored in parser type structure as long as is needed for
parsing.
There is another PR with a test containing a large yaml file #30