Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/time objects in service responses & entities not immutable #25

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Date/time objects in service responses & entities not immutable #25

merged 8 commits into from
Oct 23, 2020

Conversation

gomzyakov
Copy link
Contributor

@gomzyakov gomzyakov commented Oct 22, 2020

Description

  • Date/time objects in service responses & entities not immutable (DateTimeImmutable instead DateTime)

Fixes #21

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@gomzyakov gomzyakov marked this pull request as draft October 22, 2020 13:19
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #25   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       588       588           
===========================================
  Files             42        42           
  Lines           1338      1338           
===========================================
  Hits            1338      1338           
Flag Coverage Δ Complexity Δ
#php 100.00% <100.00%> (ø) 588.00 <41.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/DateTimeFactory.php 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
src/Responses/DevTokenResponse.php 100.00% <100.00%> (ø) 15.00 <1.00> (ø)
src/Responses/Entities/Balance.php 100.00% <100.00%> (ø) 15.00 <4.00> (ø)
src/Responses/Entities/Domain.php 100.00% <100.00%> (ø) 23.00 <4.00> (ø)
src/Responses/Entities/Group.php 100.00% <100.00%> (ø) 23.00 <4.00> (ø)
src/Responses/Entities/Report.php 100.00% <100.00%> (ø) 33.00 <4.00> (ø)
src/Responses/Entities/ReportMade.php 100.00% <100.00%> (ø) 8.00 <3.00> (ø)
src/Responses/Entities/ReportType.php 100.00% <100.00%> (ø) 39.00 <4.00> (ø)
src/Responses/Entities/User.php 100.00% <100.00%> (ø) 31.00 <4.00> (ø)
src/Responses/UserBalanceResponse.php 100.00% <100.00%> (ø) 13.00 <2.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e55cb...a5a214a. Read the comment docs.

@gomzyakov gomzyakov changed the title Replace DateTime with DateTimeImmutable Date/time objects in service responses not immutable Oct 22, 2020
@gomzyakov gomzyakov marked this pull request as ready for review October 22, 2020 13:49
@gomzyakov gomzyakov changed the title Date/time objects in service responses not immutable Date/time objects in service responses & entities not immutable Oct 22, 2020
@tarampampam tarampampam merged commit 91f5955 into avtocod:master Oct 23, 2020
@tarampampam
Copy link
Contributor

👍 Great thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTime imutable
3 participants