Merged
Conversation
Contributor
Author
|
Since the whole idea with |
Contributor
|
I think we should remove it as well. |
added 2 commits
June 19, 2018 12:16
Contributor
Author
|
I think anything depending on the things relating to |
paulyoung
commented
Jun 19, 2018
bower.json
Outdated
| "purescript-either": "^4.0.0", | ||
| "purescript-enums": "^4.0.0", | ||
| "purescript-foldable-traversable": "^4.0.0", | ||
| "purescript-formatters": "slamdata/purescript-formatters#ee2a7e93dd124a71e188a75b002289bfffe4618e", |
Contributor
Author
There was a problem hiding this comment.
We should wait on this.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
This was merged, so we can change this to v4.0.0.
paulyoung
commented
Jun 19, 2018
bower.json
Outdated
| "purescript-tuples": "^5.0.0", | ||
| "purescript-unicode": "^4.0.0", | ||
| "purescript-numbers": "^6.0.0", | ||
| "purescript-decimals": "sharkdp/purescript-decimals#8ad1954ccd6cc4cbbca76e5772f802e12c387ce8" |
Contributor
Author
There was a problem hiding this comment.
We should also wait on this.
Contributor
Author
There was a problem hiding this comment.
paulyoung
commented
Jun 19, 2018
| "purescript-spec-discovery": "^2.0.0" | ||
| "purescript-psci-support": "^4.0.0", | ||
| "purescript-spec": "^3.0.0", | ||
| "purescript-spec-discovery": "owickstrom/purescript-spec-discovery#06d37dbdb2f456a95b68543cc8a0371dbebf87b5" |
Contributor
Author
There was a problem hiding this comment.
We might want to wait on this.
Contributor
Author
There was a problem hiding this comment.
natefaubion
approved these changes
Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically done except that
Localewas removed inpurescript-datetimev4.0.0.I'm putting this up to discuss the way forward.