Skip to content

Use fixed-point notation in toString #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulyoung merged 1 commit into from
Jul 3, 2018
Merged

Use fixed-point notation in toString #28

paulyoung merged 1 commit into from
Jul 3, 2018

Conversation

@paulyoung
Copy link
Contributor

@paulyoung paulyoung commented Jul 3, 2018

This fixes an issue where toString $ toSeconds $ nanoseconds 1 would produce "1e-9s" instead of "0.000000001s".

> Decimal.toString $ Decimal.fromNumber 0.000000001
"1e-9"

> Decimal.toFixed 9 $ Decimal.fromNumber 0.000000001
"0.000000001"

@paulyoung paulyoung self-assigned this Jul 3, 2018
@paulyoung paulyoung merged commit b888045 into master Jul 3, 2018
@paulyoung paulyoung deleted the paulyoung/to-fixed branch July 3, 2018 20:01
@paulyoung
Copy link
Contributor Author

paulyoung commented Jul 3, 2018

I think we need to revert this.

Unsurprisingly, this is now producing "1.000000000s" instead of "1s", etc.

paulyoung pushed a commit that referenced this pull request Jul 3, 2018
Revert "Use fixed-point notation in toString (#28)"
a72f592 
This reverts commit b888045.
@paulyoung paulyoung mentioned this pull request Jul 3, 2018
Merged
paulyoung added a commit that referenced this pull request Jul 3, 2018
@paulyoung
Revert "Use fixed-point notation in toString (#28)" (#29)
282ce5a 
This reverts commit b888045.
@paulyoung paulyoung mentioned this pull request Jul 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinwahl colinwahl colinwahl approved these changes

Assignees

@paulyoung paulyoung

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulyoung @colinwahl