Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming theup metric #27

Closed
bluecmd opened this issue Jul 20, 2021 · 2 comments
Closed

Consider renaming theup metric #27

bluecmd opened this issue Jul 20, 2021 · 2 comments

Comments

@bluecmd
Copy link

bluecmd commented Jul 20, 2021

Hi,

Background:

$ curl localhost:4000/metrics
# HELP up UP Status
# TYPE up gauge
up 1
[..]

up is a auto-generated metric by Prometheus often assumed to be referring to whether the exporter is reachable or not. By including it in the response it causes e.g. the commonly used TargetDown alert to fire which are usually only for exporters themselves - e.g. checking the Prometheus "Targets" page would not list this instance. Indeed, given that the up metric does not contain anything to differentiate itself, it is virtually impossible to distinguish between "Is the exporter down, or the whole database?".

Instead, if you look at other black-box style exporters you see probe_success and similar metrics.

Thanks for your consideration,
cobolbaby added a commit to cobolbaby/prometheus-mssql-exporter that referenced this issue Jul 25, 2021
@cobolbaby
feat: Rename the up metric awaragi#27
e7957b8
@cobolbaby cobolbaby mentioned this issue Jul 25, 2021
Closed
@awaragi
Copy link
Owner

awaragi commented Mar 20, 2022

Thank you for raising the issue. Although late, I have incorporated the change in the next release.

awaragi pushed a commit that referenced this issue Mar 20, 2022
renamed up metric to mssql_up based on #27
4a2069f 
updated docker run command to be more self contained and cleans up after itself
rename test server to start
@awaragi awaragi mentioned this issue Mar 20, 2022
Merged
awaragi added a commit that referenced this issue Mar 20, 2022
@awaragi
Merge pull request #33 from awaragi/version-1.0
619d0c2 
Updated documentation including how to test and develop locally
Updated version of package to 1.0.0
Added docker run script to build and launch server in container
updated to latest LTS nodejs base image
Renamed up metric to mssql_up based on Consider renaming theup metric #27
Fixed issue The mssql_database_filesize metrics fails on big databases #25
Ran prettier (finally)
Added github workflow (on release publish -> push to dockerhub)
@awaragi
Copy link
Owner

awaragi commented Mar 20, 2022

Please note that release 1.0.x is out and include this request

@awaragi awaragi closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluecmd @awaragi