-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1 #34
Merged
Merged
Version 1.1 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incorporate changes to index.js based on code in #28
formatted code
Updated README with list of metrics
Hey @cobolbaby. Perhaps if you can and have some free time take a quick look at this PR |
This was
linked to
issues
Mar 21, 2022
This was
linked to
issues
Mar 24, 2022
Closed
added package-lock.json for deterministic builds added .npmrc so that builds work regardless of environment switch npm install to npm ci (faster and ensures that package-lock.json is present updated version of express (3 high risks indicated by npm audit)
@awaragi Great to see you back in the community. I have compared the relevant changes and the version 1.1 has fully covered all the expected changes. |
Thanks for the kind words. Glad to be back. I will try to be more active with requests going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.