Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hostname resolution #586

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Added hostname resolution #586

merged 1 commit into from
Aug 29, 2023

Conversation

lougovsk
Copy link
Contributor

Currently one mqtt client requires an ip address. However, often we want to use hostname instead. This change should account for that

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Currently one mqtt client requires an ip address. However, often we want to use hostname instead. This change should account for that
@awawa-dev
Copy link
Owner

Hi
In the past, we had a lot of problems with similar approach, for example when HyperHDR was running in a virtual container and several subnets were available. Then during such address auto-detection we didn't always get the one on the same subnet as the target we were supposed to communicate with (for example: #580). Alternatively, would manually entering the host address in the MQTT configuration solve the problem?

@awawa-dev
Copy link
Owner

Nevermind, it's a target. Should work.

@awawa-dev awawa-dev added this to the v20 milestone Jul 24, 2023
@awawa-dev awawa-dev merged commit 7b5d756 into awawa-dev:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants