Fix: time()
being appended regardless of pre-existing file with same filename
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems that regardless of a file existing or not,
time()
is appended to the filename, which it appears should only occur when the file does in fact exist.Solution
$filename
to a string for cases where it is equal to the return ofStr::uuid()
, to avoid Livewire throwing an exception about an invalid component property type if it does not havetime()
concatenated to it (effectively converting it to a string).Testing
should_preserve_filenames = true
should_preserve_filenames = false