Ensure curation visibility matches original image #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This seems reasonable to me. Will test further and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @awcodes!
I was wondering if you thought this implementation would make sense to ensure that curations always have the same visibility as the original image they are a curation of.
Although Curations are saved into the media table with the same visibility of their original image, when using some S3 compatible storage options (Digital Ocean Spaces specifically 😮💨), all resources are created as private unless otherwise specified. This results in them showing as public per the Media/Curation record, but actually existing as private since visibility was not specified.
This would fix that issue, and ensure that the functionality remains the same for everyone else who may be able to configure default visibility on a bucket differently.