Update cr.yml #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -10,7 +10,8 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| if: ${{ contains(github.event.*.labels.*.name, 'gpt review') }} # Optional; to run only when a label is attached | |||
| # Optional; to run only when a label is attached | |||
| # if: ${{ contains(github.event.*.labels.*.name, 'gpt review') }} | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: anc95/ChatGPT-CodeReview@main | |||
There was a problem hiding this comment.
这是一段通过 GitHub Action 运行 ChatGPT 代码审查的代码片段。下面是我对这段代码的简要评估：
- 第 10 行和第 11 行之间的 if 语句被注释掉了，所以在运行时无论标签是否附加都会运行。
- 此处没有检查代码库中的 github.event 值是否存在，如果不存在，则会导致错误.
- 没有任何风险也没有明显的优化建议。
因此，如果您希望仅在附加了“gpt review”标签时才运行测试作业，则需要取消注释第 11 行并引入一个条件语句以判断github.event值是否存在，并根据需要做出相应的更改。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request