Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KP_ENTER is ignored in main menu #3867

Closed
unknown321 opened this issue Nov 14, 2023 · 2 comments
Closed

KP_ENTER is ignored in main menu #3867

unknown321 opened this issue Nov 14, 2023 · 2 comments

Comments

@unknown321
Copy link
Contributor

Output of awesome --version:

$ awesome --version
awesome v4.3 (Too long)
 • Compiled against Lua 5.3.6 (running with Lua 5.3)
 • D-Bus support: ✔
 • execinfo support: ✔
 • xcb-randr version: 1.6
 • LGI version: 0.9.2

How to reproduce the issue:

Press Super-W to open main menu. Highlight entry (using arrow keys/mouse) and press numpad enter (KP_ENTER).

Actual result:

Nothing happens

Expected result:

Menu entry starts, like on regular enter press.

@unknown321
Copy link
Contributor Author

Patch:

---- /usr/share/awesome/lib/awful/menu.lua	2023-11-17 21:37:00.270213981 +0300
+++ /usr/share/awesome/lib/awful/menu.lua	2023-11-17 21:37:46.518324482 +0300
@@ -107,7 +107,7 @@
               down = { "Down", "j" },
               back = { "Left", "h" },
               exec = { "Return" },
-              enter = { "Right", "l" },
+              enter = { "Right", "l", "KP_Enter" },
               close = { "Escape" } }

Not sure if this is a right place to patch, still works for me.

@Elv13
Copy link
Member

Elv13 commented Nov 19, 2023

Can you submit a pull request? You can do this directly on the GitHub web UI by pressing edit or in a terminal

mergify bot added a commit that referenced this issue Nov 19, 2023
@Elv13 Elv13 closed this as completed Nov 19, 2023
duxedo pushed a commit to duxedo/awesome that referenced this issue Mar 24, 2024
sicelo added a commit to sicelo/awesome that referenced this issue Dec 23, 2024
In Awesome's menu system, the KP_Enter key is currently used the same
as the Right key (to descend into a child menu). This is unexpected,
since in general, users expect KP_Enter to work similar to the Return
key (to run the highlighted action/command). This commit corrects that
behavior.

Related: awesomeWM#3867

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
sicelo added a commit to sicelo/awesome that referenced this issue Dec 23, 2024
In Awesome's menu system, the KP_Enter key is currently used the same
as the Right key (to descend into a child menu). This is unexpected,
since in general, users expect KP_Enter to work similar to the Return
key (to run the highlighted action/command). This commit corrects that
behavior.

Related: awesomeWM#3867

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants