Drag and Drop file uploads with uppy #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uppy holds on to files so you can't upload duplicates, but this is a problem if you add a file, remove it with the "remove" button, then decide you want to add it back again. We now hold on to the internal uppy file ID in a data element so we can remove it.
jcn
force-pushed
the
jcn/image-uploads
branch
from
42f77b0 to
599d854
Compare
Still need to add an "application description" which would be more descriptive language about why this image was included vs just a caption, as well as adding an alt text field, but we will iterate to get that right in the future.
It seems to me like you'll never want to re-use a photo caption so I think the autocomplete would just be confusing.
…nst Uppy's filecount Uppy keeps track of uploaded files, which is useful when autoproceed is off, but when it is on, then once a file is successfully uploaded we don't want it to be in Uppy's internal upload list because those files also count against the total number of files allowed as per the restrictions hash. i.e. If a project has 3 images, and you upload one, then reset the restrictions to 1 remaining, you will be unable to upload any more because the one you just uploaded will be the "1" that you are restricted to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the old s3_file_field gem with uppy and add a
captionfield to uploaded images.Also, this hopefully addresses #211 (still have no idea what is causing this but hopefully switching to Uppy will prevent it).