Remove println! from software fallback
#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonxjames
changed the title
println! from software fallback
|
Good catch, thanks for the fix! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Fixing #3, the software fallback was unconditionally using
println!(), so logging for all consumersThe Solution
I removed that log.
Changes
[ A more detailed explanation of the solution to guide reviewers. Point out tricky or magic areas. ]
Planned version bump
PATCH]Links
println!()statements with configurable logging #3Notes
[ @mentions for anyone who should be alerted to this PR ]
[ Please assign reviewers if you want someone specific to review this ]
[ Please do not forget to add labels specific to this PR ]