CA fixes.

awgil · Oct 19, 2024 · 10f0cd0 · 10f0cd0
1 parent 60a0119
commit 10f0cd0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/BossMod/QuestBattle/Dawntrail/MSQ/TheProtectorAndTheDestroyer.cs b/BossMod/QuestBattle/Dawntrail/MSQ/TheProtectorAndTheDestroyer.cs
@@ -3,7 +3,7 @@
 [ZoneModuleInfo(BossModuleInfo.Maturity.Contributed, 998)]
 public class TheProtectorAndTheDestroyer(WorldState ws) : QuestBattle(ws)
 {
-    public unsafe override List<QuestObjective> DefineObjectives(WorldState ws)
+    public override List<QuestObjective> DefineObjectives(WorldState ws)
     {
         if (ws.Party.Player()?.PosRot.Y > 50)
             return [];

diff --git a/BossMod/QuestBattle/QuestBattle.cs b/BossMod/QuestBattle/QuestBattle.cs
@@ -260,7 +260,9 @@ public abstract class QuestBattle : ZoneModule
 
     protected QuestBattle(WorldState ws) : base(ws)
     {
+#pragma warning disable CA2214 // TODO: this is kinda working rn, but still not good...
         Objectives = DefineObjectives(ws);
+#pragma warning restore CA2214
 
         _subscriptions = new(
             ws.Actors.EventStateChanged.Subscribe(act => CurrentObjective?.OnActorEventStateChanged?.Invoke(act)),
@@ -320,6 +322,8 @@ protected override void Dispose(bool disposing)
         // TODO: get rid of stuff below, this is bad...
         if (Service.Condition != null)
             Service.Condition.ConditionChange -= OnConditionChange;
+
+        base.Dispose(disposing);
     }
 
     public override void Update()