fix AI positional #423
Merged
fix AI positional #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old version of this code called SelectBetterTarget from the rotation, which would choose target, range, and positional, but now we don't do that.
also the old code had the rear and front positional check inverted, so ai mode didn't like that very much and thought it was always in the wrong place
i would like to separate Positional.Front from PreferTanking - because front positionals are actually a thing for blue mage and you only need to be within the front 90 degrees of the target, like any other positional - but didn't put it in here
tested on striking dummy with dragooner and monk