ClassPLDUtility.cs update; ClassDRKUtility.cs implementation #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Akechi-kun
commented
Aug 20, 2024
•
Akechi-kun
commented
- Add Stance to all Tank Utility modules
- Test Stance & rest of general Tank actions listed in Utility module
- Add appropriate actions related to PLD/DRK
- Add CDPlanner support for PLD/DRK
- Test CDPlanner support for PLD/DRK
Akechi-kun
changed the title
awgil
reviewed
Aug 22, 2024
| @@ -29,7 +29,7 @@ protected static void DefineShared(RotationModuleDefinition def, ActionID lb3, A | |||
| DefineSimpleConfig(def, SharedTrack.Shirk, "Shirk", "", 150, ClassShared.AID.Shirk); | |||
| DefineSimpleConfig(def, SharedTrack.ArmsLength, "ArmsLength", "ArmsL", 300, ClassShared.AID.ArmsLength, 6); // note: secondary effect 15s | |||
|
|
|||
| def.Define(SharedTrack.Stance).As<StanceOption>("Stance", "", -10) | |||
| def.Define(SharedTrack.Stance).As<StanceOption>("Stance", "", 10) | |||
There was a problem hiding this comment.
The reason these things were negative is to hide them by default, since they are so rarely useful (i.e. interject is needed for like 1 fight). Stance is probably more useful for offtanks, so I guess making it positive is reasonable.
However, I've just realized that 'usual' (non-replay-based) UI for cdplan has no way of toggling column visibility! Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.