Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[akechi/Utility] fixes, adjustments, & new additions #557

Merged
merged 34 commits into from
Dec 30, 2024

Conversation

Akechi-kun
Copy link
Contributor

@Akechi-kun Akechi-kun commented Dec 14, 2024

This PR features a small refactor of both my GNB & DRG modules; removing some obsolete helpers/functions whilst fixing & adjusting plenty of logic. I have also added plenty of new optimization options for a lot of different abilities across the board.
I have also taken the liberty of fixing some improper double-use cases & plenty of targeting issues when using Utility modules, as most either only went to primaryTarget or self, regardless of target choice inside the CDPlanner. Alas, this PR should fix all this, as well as added a few more options into a couple modules. (e.g. NIN's Skukuchi is now available)
(NOTE: Some of these changes may require some readjustment to existing plans/presets for AkechiGNB & AkechiDRG.. however, the additional effort invested in refining each said plan/preset will prove to be highly beneficial with the amount of optimization & flexibility now available to users.)

AkechiDRG

  • Remove BurstStrategy
  • Remove obsolete rotation option from AOEStrategy
  • Add CooldownStrategy in replacement of BurstStrategy
  • Add new logic & options into PiercingTalonStrategy to comply with Enhanced Piercing Talon addition
  • Add SpearTargetingStrategy for intricate target planning & strategizing for Geirskogul, Nastrond, & Wyrmwind Thrust
  • Add AutoTargetMostPrimary & AutoTargetMostHit options into SpearTargetingStrategy
  • Add Force Weave option into OffensiveStrategy, SurgeStrategy, JumpStrategy, DragonfireStrategy, GeirskogulStrategy, & StardiverStrategy
  • Add ForceNextOpti, & ForceNextOptiWeave options into SurgeStrategy
  • Add DivesStrategy for intricate planning & strategizing for when/how to use Jump, Stardiver, & Dragonfire Dive
  • Add MaxRange, CloseRange, Allow, & Forbid options to DivesStrategy
  • Add comments
  • Spring-cleaning
  • Test

AkechiGNB

  • Fix issue with auto-target options breaking combo regardless of selection for AOEStrategy
  • Remove OffensiveStrategy
  • Remove BurstStrategy
  • Remove Burst Strike and Fated Circle option
    (NOTE: these have been changed into options for CartridgesStrategy)
  • Add CooldownStrategy in replacement of BurstStrategy
  • Add Hold option to CooldownStrategy
  • Add GCDStrategy and OGCDStrategy in replacement of OffensiveStrategy
    [NOTE: The reason for this was to separate GCDs from oGCDs whilst still using them as a general offensive strategy. Plus to be able to add stuff with weaving capabilities (e.g. Force Weave options)]
  • Add AnyWeave, EarlyWeave, & LateWeave options to OGCDStrategy
  • Add CartridgesStrategy for intricate gauge planning & strategizing
  • Add Burst Strike, Fated Circle, Gnashing Fang, Double Down, and Conserve to CartridgeStrategy
  • Add ReignStrategy for intricate Reign of Beasts planning & strategizing
  • Add ForceReign, ForceNoble, and ForceLion to ReignStrategy
  • Add a shitload of options to NoMercyStrategy, literally every possible way of optimizing this ability
  • Refactor LightningShotStrategy options
  • Add comments
  • Spring-cleaning
  • Test

AkechiSCH

  • Implement
  • Fix warnings/errors
  • Cleanup
  • Test

Other

  • Fix Bug: Sacred Soil does not work above level 60 using the Cooldown Planner. #546
  • Fix BUG: Oblation being used twice in a row when used via the CD planner. #558
  • Add Enhanced Piercing Talon (SID) into \ActionQueue\Melee\DRG.cs
  • Add appropriate Tsubame-gaeshi (SID) into \ActionQueue\Melee\SAM.cs
  • Add Oblation (SID) into \ActionQueue\Tanks\DRK.cs
  • Add Chain Stratagem (SID) into \ActionQueue\Healers\SCH.cs
  • Add Seraphism (SID) into \ActionQueue\Healers\SCH.cs
  • Add Fey Union (SID) into \ActionQueue\Healers\SCH.cs
  • Add Shukuchi to ClassNINUtility
  • Add Earthly Star to ClassASTUtility
  • Add SCHConfig.cs to \ActionTweaks\ClassActions
  • Fix issues with double-use of various abilities with charges across various jobs inside Utility folder
  • Fix issues with choice of targeting for various abilities across various jobs inside Utility folder

@Akechi-kun Akechi-kun changed the title [AkechiDRG] 7.1 adjustments & additions [AkechiGNB/AkechiDRG] fixes, adjustments, & new additions Dec 18, 2024
@Akechi-kun Akechi-kun changed the title [AkechiGNB/AkechiDRG] fixes, adjustments, & new additions [akechi/Utility] fixes, adjustments, & new additions Dec 24, 2024
@awgil awgil merged commit e8aba80 into awgil:master Dec 30, 2024
1 check failed
@Akechi-kun Akechi-kun deleted the hmph branch December 30, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants