-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[akechi/Utility] fixes, adjustments, & new additions #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akechi-kun
changed the title
[AkechiDRG] 7.1 adjustments & additions
[AkechiGNB/AkechiDRG] fixes, adjustments, & new additions
Dec 18, 2024
added QueueGCD/OGCD from xan's files, as this has the appropriate code for ground targeting abilities
Akechi-kun
changed the title
[AkechiGNB/AkechiDRG] fixes, adjustments, & new additions
[akechi/Utility] fixes, adjustments, & new additions
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR features a small refactor of both my
GNB
&DRG
modules; removing some obsolete helpers/functions whilst fixing & adjusting plenty of logic. I have also added plenty of new optimization options for a lot of different abilities across the board.I have also taken the liberty of fixing some improper double-use cases & plenty of targeting issues when using
Utility
modules, as most either only went toprimaryTarget
orself
, regardless of target choice inside theCDPlanner
. Alas, this PR should fix all this, as well as added a few more options into a couple modules. (e.g.NIN's Skukuchi
is now available)(NOTE: Some of these changes may require some readjustment to existing plans/presets for
AkechiGNB
&AkechiDRG
.. however, the additional effort invested in refining each said plan/preset will prove to be highly beneficial with the amount of optimization & flexibility now available to users.)AkechiDRG
BurstStrategy
AOEStrategy
CooldownStrategy
in replacement ofBurstStrategy
PiercingTalonStrategy
to comply withEnhanced Piercing Talon
additionSpearTargetingStrategy
for intricate target planning & strategizing forGeirskogul
,Nastrond
, &Wyrmwind Thrust
AutoTargetMostPrimary
&AutoTargetMostHit
options intoSpearTargetingStrategy
Force Weave
option intoOffensiveStrategy
,SurgeStrategy
,JumpStrategy
,DragonfireStrategy
,GeirskogulStrategy
, &StardiverStrategy
ForceNextOpti
, &ForceNextOptiWeave
options intoSurgeStrategy
DivesStrategy
for intricate planning & strategizing for when/how to useJump
,Stardiver
, &Dragonfire Dive
MaxRange
,CloseRange
,Allow
, &Forbid
options toDivesStrategy
AkechiGNB
AOEStrategy
OffensiveStrategy
BurstStrategy
Burst Strike
andFated Circle
option(NOTE: these have been changed into options for
CartridgesStrategy
)CooldownStrategy
in replacement ofBurstStrategy
Hold
option toCooldownStrategy
GCDStrategy
andOGCDStrategy
in replacement ofOffensiveStrategy
[NOTE: The reason for this was to separate GCDs from oGCDs whilst still using them as a general offensive strategy. Plus to be able to add stuff with weaving capabilities (e.g.
Force Weave
options)]AnyWeave
,EarlyWeave
, &LateWeave
options toOGCDStrategy
CartridgesStrategy
for intricate gauge planning & strategizingBurst Strike
,Fated Circle
,Gnashing Fang
,Double Down
, andConserve
toCartridgeStrategy
ReignStrategy
for intricateReign of Beasts
planning & strategizingForceReign
,ForceNoble
, andForceLion
toReignStrategy
NoMercyStrategy
, literally every possible way of optimizing this abilityLightningShotStrategy
optionsAkechiSCH
Other
Enhanced Piercing Talon
(SID
) into\ActionQueue\Melee\DRG.cs
Tsubame-gaeshi
(SID
) into\ActionQueue\Melee\SAM.cs
Oblation
(SID
) into\ActionQueue\Tanks\DRK.cs
Chain Stratagem
(SID
) into\ActionQueue\Healers\SCH.cs
Seraphism
(SID
) into\ActionQueue\Healers\SCH.cs
Fey Union
(SID
) into\ActionQueue\Healers\SCH.cs
Shukuchi
toClassNINUtility
Earthly Star
toClassASTUtility
SCHConfig.cs
to\ActionTweaks\ClassActions
Utility
folderUtility
folder