-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: upgrade to use nodejs v16 #413
runtime: upgrade to use nodejs v16 #413
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Should be a major version bump per the PR merge. |
Would love to see this one merged and a |
@chenrui333 can you resolve the conflicts so we can get this merged? |
What is the state of this? I also got warnings in my workflow. Also happy to open a new PR to get this resolved. Please let me know. |
We're fully relying on this github action. I hope this will be merged and released as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I've Tweeted AWS they reply more often than you would think. 😄 Otherwise, might be good if some users with business support in AWS maybe open a new case/ticket to get some eyes on this ASAP? At the very least the only change actually needed is (if in a pinch): using: node16 the rest of the changes are good, but not critical path (just being aware there is a current conflict with If this does fail badly - my quick pivot will be a fork and patch of this action until this source action has been fixed/updated. |
Hi folks, I resolved the conflicts on this branch and opened a new PR with @chenrui333's changes: #520 Please have a look and let me know if I need to change anything else. |
Would love to see this PR get merged |
We really appreciate the contribution @chenrui333, However I will be closing this out because a newer PR with resolved merge conflicts has been opened #520, and we might not be able to merge that either. See this comment for more info on the plan to update runtime, and please refer to that thread for future updates and concerns regarding this topic. Thanks! |
Issue #, if available:
Description of changes:
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.