-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: upgrade to use nodejs v16 #47
runtime: upgrade to use nodejs v16 #47
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Should be a major version bump per the PR merge. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Thanks for working on this!
I assume you're referring to the actions used in the workflows and not |
Co-authored-by: Chris Rehn <crehn@outlook.com>
almost forgot the node 16 lambda issue 🤦 I am still watching it though. Yeah, you are totally correct, just the workflow runtime, not the lambda runtime. |
Side question, when is node 16 going to be rolled out for AWS lambda. :) |
Merged; thanks for the contribution!
You'll have to keep an eye out on the issue above I'm afraid. |
I'm a little adamant to push work on users by introducing a Considering Node's track record of backward compatibility, I don't see why we couldn't write Node 12-compatible code and let people's actions happily chug along without changes. Of course if the runner itself lacks fallback logic to use whatever Node version available on the host (wasn't obvious at first glance), it could cause breakages for customers running outdated self-hosted runners, in which case a |
@chenrui333 We've released (For posterity, I asked for guidance in actions/runner#1824 regarding the major version update) |
Description
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.
Checklist
npm run all
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.