Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: upgrade to use nodejs v16 #47

Merged
merged 5 commits into from
Apr 4, 2022
Merged

runtime: upgrade to use nodejs v16 #47

merged 5 commits into from
Apr 4, 2022

Conversation

chenrui333
Copy link
Contributor

Description

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Contributor Author

Should be a major version bump per the PR merge.

@hoffa
Copy link
Contributor

hoffa commented Apr 4, 2022

Thanks for working on this!

Should be a major version bump per the PR merge.

I assume you're referring to the actions used in the workflows and not setup-sam itself?

.github/workflows/test.yml Outdated Show resolved Hide resolved
Co-authored-by: Chris Rehn <crehn@outlook.com>
@chenrui333
Copy link
Contributor Author

chenrui333 commented Apr 4, 2022

Thanks for working on this!

Should be a major version bump per the PR merge.

I assume you're referring to the actions used in the workflows and not setup-sam itself?

almost forgot the node 16 lambda issue 🤦 I am still watching it though.

Yeah, you are totally correct, just the workflow runtime, not the lambda runtime.

@chenrui333
Copy link
Contributor Author

chenrui333 commented Apr 4, 2022

Side question, when is node 16 going to be rolled out for AWS lambda. :)

@hoffa hoffa merged commit 8cbdb02 into aws-actions:main Apr 4, 2022
@hoffa
Copy link
Contributor

hoffa commented Apr 4, 2022

Merged; thanks for the contribution!

Side question, when is node 16 going to be rolled out for AWS lambda. :)

You'll have to keep an eye out on the issue above I'm afraid.

@chenrui333 chenrui333 deleted the update-runtime-to-nodejs@16 branch April 4, 2022 21:26
@hoffa
Copy link
Contributor

hoffa commented Apr 4, 2022

I'm a little adamant to push work on users by introducing a v2, when neither the interface nor the action's code has changed.

Considering Node's track record of backward compatibility, I don't see why we couldn't write Node 12-compatible code and let people's actions happily chug along without changes. Of course if the runner itself lacks fallback logic to use whatever Node version available on the host (wasn't obvious at first glance), it could cause breakages for customers running outdated self-hosted runners, in which case a v2 would seem (unfortunately) a reasonable choice.

@hoffa
Copy link
Contributor

hoffa commented Apr 28, 2022

@chenrui333 We've released setup-sam@v2, thanks for the contribution!

(For posterity, I asked for guidance in actions/runner#1824 regarding the major version update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants