-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply workaround to install Pyyaml #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
approved these changes
Jul 17, 2023
hoffa
reviewed
Jul 17, 2023
hawflau
changed the title
Apply workaround to isntall Pyyaml
Apply workaround to install Pyyaml
Jul 17, 2023
ssenchenko
approved these changes
Jul 18, 2023
@hoffa are you the only maintainer? I cannot start the workflow |
hawflau
commented
Jul 18, 2023
@hoffa Can you please Approve this Fast? Our Production is Down. 🚨 |
Can you please approve this ASAP. 🚨🚨🚨 |
hoffa
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#82
Description
Latest version of Cython (3.0.0) breaks installation of PyYAML 5.4.1, a dependency of SAM CLI.
We cannot bump PyYAML version in SAM CLI due to requirement from other dependencies. For now we are using this workaround to unblock customers.
Checklist
npm run all
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.