fix(datastore): optimize sync queries with predicates by wrapping in an AND group #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardmcclellan
changed the title
richardmcclellan
changed the title
jamesonwilliams
approved these changes
Mar 12, 2021
| // provided syncPredicate is already a QueryPredicateGroup, this is not needed. If the provided | ||
| // group is of type AND, the optimization will occur. If the top level group is OR or NOT, the | ||
| // optimization is not possible anyway. | ||
| syncPredicate = new QueryPredicateGroup(QueryPredicateGroup.Type.AND, Arrays.asList(syncPredicate)); |
There was a problem hiding this comment.
This might look better wrapped into a factory method:
QueryPredicateGroup.andOf(syncPredicate)It would prevent the access escalation of the constructor, too.
There was a problem hiding this comment.
I had considered something like that, but couldn't come up with a good name for the method itself. I think andOf works though - I'll do that!
jamesonwilliams
approved these changes
Mar 12, 2021
jamesonwilliams
approved these changes
Mar 12, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a filter is provided on a sync operation, AppSync will attempt to optimize the request by performing a DynamoDB query, rather than a scan. A query is only possible if the filter contains the hash key, or the hash key and the sort key. To perform this optimization, the AppSync resolver requires the presence of a top level "and" group.
This PR wraps the sync expression filter with an AND group if the predicate provided by the customer is just a predicate operation, rather than a group.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.