-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(DataStore): Update schemas for use 'sub' as default identity claim feature #1633
Open
div5yesh
wants to merge
21
commits into
main
Choose a base branch
from
chore/idclaim-sub-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div5yesh
added
cli
Issues with the Amplify CLI, waiting to be transfered into amplify-cli.
datastore
DataStore category/plugins
infrastructure
CI/CD, test frameworks, backend resources, etc.
labels
Jan 21, 2022
gpanshu
previously approved these changes
Feb 15, 2022
sktimalsina
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase and test fixes.
Otherwise LGTM!
auto-merge was automatically disabled
April 19, 2023 15:39
Merge queue setting changed
…all onFailure (#2255) Co-authored-by: Matt Creaser <mattwcc@amazon.com> Co-authored-by: gpanshu <91897496+gpanshu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Issues with the Amplify CLI, waiting to be transfered into amplify-cli.
datastore
DataStore category/plugins
infrastructure
CI/CD, test frameworks, backend resources, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The change in CLI tagged release @aws-amplify/cli@7.6.8-sub-identity-claim.1 will provision backends and codegen the default identity claim as
sub
, previouslycognito:username
.This PR is running automated tests related to the usage of @auth with default owner field in the schema.
The code generated model files contains the explicit identityClaim key, which has been updated from
cognito:username
tosub
(see model schema file changes in this PR).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.